update pynac to 0.2.3

[burcin]

Yet another pynac release, including fixes for #10964, #11352 and #9240.

http://sage.math.washington.edu/home/burcin/pynac/pynac-0.2.3.spkg

Attached patch fixes some doctest to remove extra braces printed when typesetting mul objects.

CC: @kcrisman

Component: packages: standard

Author: Richard Kreckel, Jens Vollinga, Burcin Erocal

Reviewer: Karl-Dieter Crisman, François Bissey

Merged: sage-4.7.1.alpha4

Issue created by migration from https://trac.sagemath.org/ticket/11415

[burcin]

Attachment: trac_11415-remove_extra_braces.patch.gz

[kcrisman]

comment:2

I'm confused about

changeset:   197:3c39cd396893
user:        Burcin Erocal <burcin@erocal.org>
date:        Tue May 31 16:37:48 2011 +0200
summary:     Use "%lf" to print doubles instead of "%f".

Not that it seems to be affecting anything, though one would think it would print things differently...

Anyway, I don't see that in the Ginac commit list, but I don't see it mentioned in any of the relevant tickets either.

Otherwise, so far, so good. Now to look at the actual patches and tickets involved. #9240 I will probably not get to right away.

[kcrisman]

Reviewer: Karl-Dieter Crisman

[kcrisman]

comment:3

Positive review on the patch in this ticket.

[kcrisman]

comment:4

Positive review modulo an answer to the question about why the change from && to & was necessary in the Pynac patch for #9240.

[kiwifb]

comment:5

Replying to @kcrisman:

I'm confused about

changeset:   197:3c39cd396893
user:        Burcin Erocal <burcin@erocal.org>
date:        Tue May 31 16:37:48 2011 +0200
summary:     Use "%lf" to print doubles instead of "%f".

Not that it seems to be affecting anything, though one would think it would print things differently...

Hi Karl,

Burcin introduced this on my report because gcc complains. See here https://bitbucket.org/burcin/pynac/issue/2/correct-format-in-numericcpp. This is not about printing but about entering data if you look at the commit https://bitbucket.org/burcin/pynac/changeset/3c39cd396893 this is in scanf not printf. So printing is not affected.

[kcrisman]

comment:6

Burcin introduced this on my report because gcc complains. See here https://bitbucket.org/burcin/pynac/issue/2/correct-format-in-numericcpp. This is not about printing but about entering data if you look at the commit https://bitbucket.org/burcin/pynac/changeset/3c39cd396893 this is in scanf not printf. So printing is not affected.

Thanks, Francois! I have to say, David Kirkby would love this - someone fixing a warning and not just an actual error in an upstream package! If you watch Sage compile, it's amazing just how many warnings there are - small wonder we need gcc!

And since I know very little about C and its derivatives (enough to get in trouble, I guess), that explanation was actually very helpful.

Now I just need to know the answer about the bitwise and versus boolean and.

[kiwifb]

comment:7

I actually didn't report all the warnings. Just the easy to fix one. There's some of that as well:

/scratch/portage/sci-libs/pynac-0.2.2/work/pynac-0.2.2/src/ginac/numeric.cpp: In function 'PyObject* Integer(const long int&)':
/scratch/portage/sci-libs/pynac-0.2.2/work/pynac-0.2.2/src/ginac/numeric.cpp:173:56: warning: deprecated conversion from string constant to 'char*'
/scratch/portage/sci-libs/pynac-0.2.2/work/pynac-0.2.2/src/ginac/numeric.cpp: In function 'void GiNaC::coerce(GiNaC::Number_T&, GiNaC::Number_T&, const GiNaC::Number_T&, const GiNaC::Number_T&)':
/scratch/portage/sci-libs/pynac-0.2.2/work/pynac-0.2.2/src/ginac/numeric.cpp:262:67: warning: deprecated conversion from string constant to 'char*'

But you wouldn't believe how widespread this one is. Just look at your singular build logs for example when you have time.
I may attempt your other question but in #9240 (he says looking at his C manual and looking at the code).

[kcrisman]

comment:8

Yes, I've seen lots of those as well.