Remove deprecated group_algebra.py

[jdemeyer]

Remove the file src/sage/algebras/group_algebra.py which was deprecated in #6670.

Rename src/sage/algebras/group_algebra_new.py to src/sage/algebras/group_algebra.py (with deprecation).

Component: algebra

Author: Jeroen Demeyer

Branch/Commit: dbb3d10

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/17779

[jdemeyer]

Branch: u/jdemeyer/ticket/17779

[jdemeyer]

New commits:

dbb3d10

Remove deprecated group_algebra.py

[jdemeyer]

Commit: dbb3d10

[jdemeyer]

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
 Remove the file `src/sage/algebras/group_algebra.py` which was deprecated in #6670.
 
-Rename `src/sage/algebras/group_algebra_new.py` to `src/sage/algebras/group_algebra.py`.
+Rename `src/sage/algebras/group_algebra_new.py` to `src/sage/algebras/group_algebra.py` (with deprecation).

[videlec]

comment:4

Couldn't you use git rm and git mv in your commits? It would be of very much help for the reviewer...

[jdemeyer]

comment:5

Replying to @videlec:

Couldn't you use git rm and git mv in your commits?

1. That's what I did.
2. I think it doesn't make a difference to git (unlike hg where it does matter).

[jdemeyer]

comment:6

I guess your real question is: "why does git show not show the rename?"

I don't know the answer either. Perhaps it doesn't detect the rename because there is an old and new file with the name src/sage/algebras/group_algebra.py

[jdemeyer]

comment:7

After reading man git-show, I discovered the trick:

git show -B -M

does show the rename properly.

[videlec]

comment:8

It also seems that if in the same commit you use git rm/mv and modify the file then it is not clean anymore.