Replace is_package_installed with Features

[saraedum]

CC: @mkoeppe @jdemeyer @nexttime @embray @defeo @isuruf @slel

Component: build

Keywords: days85

Author: Julian Rüth, Jeroen Demeyer

Branch: ad6dcc6

Reviewer: Nicolas M. Thiéry, François Bissey, Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/20382

[saraedum]

Branch: u/saraedum/replace_is_package_installed_with_features

[kiwifb]

Commit: 7c1ca31

[kiwifb]

comment:2

Indeed same kind of work. Much more sophisticated on your part I must say. Do I understand well that you need an executable class for any external binaries that you want to call?

It could also solve the issue that I was thinking about executables and other files requirement. You should be able to find and use something already installed in a standard location. theta being already present in /usr/local/bin instead of $SAGE_LOCAL/bin (which resolves to /usr/bin in sage-on-gentoo) or anywhere in the PATH. Similarly you can install gap packages in ~/.gap/pkg and there is no reasons why you shouldn't be able to use those.

---

New commits:

3233147	Add Features to check the environment at runtime
dfd97f8	Check for grape with GapPackage instead of is_package_installed()
7c1ca31	Check for a working CSDP binary instead of is_package_installed()

[nthiery]

Changed branch from u/saraedum/replace_is_package_installed_with_features to u/nthiery/replace_is_package_installed_with_features

[sagetrac-git]

Changed commit from 7c1ca31 to 97d47af

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

97d47af

20382: missing docstring

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

8b6fcc9

20382: desirable error message + typo

[sagetrac-git]

Changed commit from 97d47af to 8b6fcc9

[kiwifb]

comment:6

Handling of database_gap will be delicate. The spkg includes bits removed stuff from gap that are expected by default (no need to load if present) and one "real" gap package that one would need to load (tomlib).

That may require special consideration.

[saraedum]

comment:7

Thanks for the pointer about database_gap. I should have a complete proposal up on the other ticket in the next 24 hours.

[kiwifb]

comment:8

I think this ticket should replace the other one unless you have a plan. I am making a list of stuff that needs to come from the other ticket and stuff that should use your feature detection. I guess we could split it along those lines.