Import abs in functions/all.py

[paulmasson]

Since abs is an explicit alias of abs_symbolic it should be explicitly imported from functions/other.py

Component: symbolics

Author: Paul Masson

Branch/Commit: u/paulmasson/import_abs_in_functions_all_py @ b36e1c4

Issue created by migration from https://trac.sagemath.org/ticket/21657

[paulmasson]

Branch: u/paulmasson/import_abs_in_functions_all_py

[paulmasson]

Commit: b36e1c4

[paulmasson]

Author: Paul Masson

[paulmasson]

New commits:

b36e1c4

Import abs

[paulmasson]

Description changed:

--- 
+++ 
@@ -1 +1 @@
-
+Since `abs` is an explicit alias of `abs_symbolic` it should be explicitly imported from `functions/other.py`

[rwst]

comment:3

Patchbot:

sage -t --long src/sage/matrix/matrix2.pyx  # 5 doctests failed
sage -t --long src/sage/symbolic/expression.pyx  # 1 doctest failed
sage -t --long src/sage/rings/continued_fraction.py  # 2 doctests failed
sage -t --long src/sage/rings/number_field/number_field_element_quadratic.pyx  # 1 doctest failed
sage -t --long src/sage/modules/free_module_element.pyx  # 2 doctests failed
sage -t --long src/sage/stats/distributions/discrete_gaussian_lattice.py  # 2 doctests failed
sage -t --long src/sage/matrix/matrix_symbolic_dense.pyx  # 2 doctests failed
sage -t --long src/sage/matrix/matrix_double_dense.pyx  # 2 doctests failed
sage -t --long src/sage/misc/sage_input.py  # 1 doctest failed
sage -t --long src/sage/libs/mpmath/ext_main.pyx  # 1 doctest failed

[rwst]

comment:4

Commenting on some of the doctest failures...

sage -t --long --warn-long 35.3 src/sage/symbolic/expression.pyx
**********************************************************************
File "src/sage/symbolic/expression.pyx", line 6868, in sage.symbolic.expression.Expression.__abs__
Failed example:
    abs(SR(-5),hold=True)
Expected:
    Traceback (most recent call last):
    ...
    TypeError: abs() takes no keyword arguments
Got:
    abs(-5)

This looks like the correct answer so just adapt the doctest.

File "src/sage/rings/continued_fraction.py", line 500, in sage.rings.continued_fraction.ContinuedFraction_base.__abs__
Failed example:
    abs(a)
Exception raised:
...
    TypeError: cannot coerce arguments: no canonical coercion from <class 'sage.rings.continued_fraction.ContinuedFraction_periodic'> to Symbolic Ring

Most fails are of this type. I think this is related to #17790.

sage -t --long src/sage/libs/mpmath/ext_main.pyx
...
      File "sage/symbolic/function.pyx", line 766, in sage.symbolic.function.Function._eval_mpmath_ (build/cythonized/sage/symbolic/function.cpp:8582)
        res = self(*args)
      File "sage/symbolic/function.pyx", line 979, in sage.symbolic.function.BuiltinFunction.__call__ (build/cythonized/sage/symbolic/function.cpp:11061)
        return custom(*args)
      File "sage/symbolic/function.pyx", line 766, in sage.symbolic.function.Function._eval_mpmath_ (build/cythonized/sage/symbolic/function.cpp:8582)
        res = self(*args)
      File "sage/symbolic/function.pyx", line 979, in sage.symbolic.function.BuiltinFunction.__call__ (build/cythonized/sage/symbolic/function.cpp:11061)
        return custom(*args)
...
    RuntimeError: maximum recursion depth exceeded while calling a Python object

This one is different, it looks like a bug in BuiltinFunction._eval_mpmath_().

[nbruin]

comment:5

Can we not merge this ticket and close it as invalid?

I think the alias should be interpreted the other way around: sage.functions.other.abs is bound because there's no name clash and this is the most logical name. In addition, there's sage.functions.other.abs_symbolic which avoids the nameclash with python's builtin abs and is therefore suitable for importing into the global namespace (does it need to be there, though?).