Fixup src/VERSION.txt added in #30912

[mkoeppe]

The mistake made in #30912 broke the direct use of src/setup.py. (Did not affect normal build.)

Depends on #30912

CC: @jhpalmieri @tobiasdiez @isuruf

Component: build

Author: Matthias Koeppe

Branch/Commit: 043d3ab

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/31357

[mkoeppe]

Branch: u/mkoeppe/fixup_src_version_txt_added_in__30912

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1 +1,2 @@
+The mistake made in #30912 broke the direct use of `src/setup.py`. (Did not affect normal build.)
 

[mkoeppe]

Commit: c16651c

[mkoeppe]

Last 10 new commits:

2a91862	build/pkgs/sagelib/src/README.rst: Add some text
6432727	Merge tag '9.3.beta2' into t/30912/sagelib__update_metadata_for_pypi_deployment
4a693f2	Move build/pkgs/sagelib/src/setup.cfg to SAGE_ROOT/src, replace by symlink
ea182d7	Copy changes from build/pkgs/sagelib/src to src
a1a10b9	src/VERSION.txt: New
5697335	src/setup.cfg: Add license_file=LICENSE.txt
deb9eb3	Merge tag '9.3.beta3' into t/30912/sagelib__update_metadata_for_pypi_deployment
7ad4c0e	Merge tag '9.3.beta4' into t/30912/sagelib__update_metadata_for_pypi_deployment
bdb2237	Merge branch 't/30912/sagelib__update_metadata_for_pypi_deployment' into t/31357/fixup_src_version_txt_added_in__30912
c16651c	src/VERSION.txt: Use same format as build/pkgs/sagelib/src/VERSION.txt

[mkoeppe]

Author: Matthias Koeppe

[jhpalmieri]

comment:3

So we're going to have the version recorded in another non-auto-generated file?

[mkoeppe]

comment:4

It is auto-generated by src/bin/sage-update-version

[mkoeppe]

comment:5

This file needs to be there at the time that one would prepare an sdist of the Sage library - which is by the end of bootstrap.
In the current implementation, all version files are updated using this script and checked in to git by the release manager when preparing a release.

[jhpalmieri]

comment:6

Should the symlink build/pkgs/sagelib/src/VERSION.txt point to SAGE_ROOT/src/VERSION.txt? Or maybe to ../package-version.txt? Right now it's pointing to the nonexistent SAGE_ROOT/src/package-version.txt.

In the sage-update-version script, the file SAGE_ROOT/src/bin/VERSION.txt is written. Should that instead be SAGE_ROOT/src/VERSION.txt?

I'm basically really confused about the different version files.

[mkoeppe]

comment:7

Thanks for catching these mistakes... I'll fix it up

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

043d3ab

Fixup version files/symlinks

[sagetrac-git]

Changed commit from c16651c to 043d3ab

[jhpalmieri]

Reviewer: John Palmieri

[jhpalmieri]

comment:9

Thanks for the fixes. I think this is okay.