Move sage.functions.other.sqrt to sage.misc.functional

[mkoeppe]

$ git grep 'functions.*import.*sqrt' finds a small number of these imports

sqrt is actually not a symbolic function, so we move it to sage.misc.functional and import it from there. isqrt already lives there.

(Alternatively, many uses of the sqrt function could be replaced by a call to the .sqrt method.)

Either way will avoid the dependency on sage.symbolic.

(Same for ceil, floor, but that could also be done via #25827.)

CC: @tscrim

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 451ac27

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32717

[mkoeppe]

Description changed:

--- 
+++ 
@@ -2,3 +2,4 @@
 
 This will avoid the dependency on `sage.symbolic`
 
+Same for `ceil`, `floor`, but that that could also be done via #25827.

[mkoeppe]

Description changed:

--- 
+++ 
@@ -2,4 +2,4 @@
 
 This will avoid the dependency on `sage.symbolic`
 
-Same for `ceil`, `floor`, but that that could also be done via #25827.
+Same for `ceil`, `floor`, but that could also be done via #25827.

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,3 +1,6 @@
+`$ git grep 'functions.*import.*sqrt'` finds a small number of these imports
+
+
 It can be replaced by a call to the `.sqrt` method
 
 This will avoid the dependency on `sage.symbolic`

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,8 +1,9 @@
 `$ git grep 'functions.*import.*sqrt'` finds a small number of these imports
 
+`sqrt` is actually not a symbolic function, so we move it to `sage.misc.functional`. `isqrt` already lives there.
 
-It can be replaced by a call to the `.sqrt` method
+Alternatively, the uses of the `sqrt` function can be replaced by a call to the `.sqrt` method.
 
-This will avoid the dependency on `sage.symbolic`
+Either way will avoid the dependency on `sage.symbolic`.
 
-Same for `ceil`, `floor`, but that could also be done via #25827.
+(Same for `ceil`, `floor`, but that could also be done via #25827.)

[mkoeppe]

Branch: u/mkoeppe/remove_use_of_sage_functions_other_sqrt__outside_of_sage_symbolic__sage_functions__sage_manifolds_

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

5952b37	src/sage/misc/all.py: Add sqrt
905e800	src/sage/misc/functional.py: Fix imports
451ac27	src/sage/functions/other.py: Remove import from sage.rings.all

[sagetrac-git]

Commit: 451ac27

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,8 +1,8 @@
 `$ git grep 'functions.*import.*sqrt'` finds a small number of these imports
 
-`sqrt` is actually not a symbolic function, so we move it to `sage.misc.functional`. `isqrt` already lives there.
+`sqrt` is actually not a symbolic function, so we move it to `sage.misc.functional` and import it from there. `isqrt` already lives there.
 
-Alternatively, the uses of the `sqrt` function can be replaced by a call to the `.sqrt` method.
+(Alternatively, many uses of the `sqrt` function could be replaced by a call to the `.sqrt` method.)
 
 Either way will avoid the dependency on `sage.symbolic`.
 

[mkoeppe]

comment:8

The failure in src/sage/rings/integer.pyx is not from this ticket

[tscrim]

comment:10

LGTM.

[tscrim]

Reviewer: Travis Scrimshaw

[mkoeppe]

comment:11

Thanks!