matrix classes for flint polynomials

[burcin]

Attached patch adds templated matrix classes for FLINT's fmpz_poly and zmod_poly structs.

At the moment there is no extra functionality provided by the classes, but fast nullspace (over the fraction field), and hopefully inverse implementations will be coming soon. In any case, this should be a good basis for implementing fast algorithms for these matrices.

CC: @malb @jpflori

Component: linear algebra

Author: Burcin Erocal

Reviewer: Martin Albrecht

Issue created by migration from https://trac.sagemath.org/ticket/8939

[burcin]

Attachment: trac_8939-matrix_template.patch.gz

Attachment: trac_8939-matrix_template-4.4.2.patch.gz

rebased to 4.4.2

[burcin]

comment:2

I uploaded a new patch rebased to 4.4.2.

[malb]

comment:3

I get one doctest failure with this patch applied on top of 4.4.2:

**********************************************************************
File "/mnt/usb1/scratch/malb/sage-4.4/devel/sage/sage/modules/free_module.py", line 1125:
    sage: V.base_extend(QQ)
Expected:
    Vector space of dimension 7 over Rational Field
Got:
    V

[malb]

comment:4

The patch looks good. However, I'd prefer to have a bit more documentation.

• I think there should be doctests in fmpz_poly_linkage.pxi. I know our policy does not require it, but it seems like a good pplace to put some
• It would be nice to write a bit about how all the files (templates etc.) relate to each other, e.g. some documentation in matrix_dense_template.pxi which makes it explains a bit how to use it. (I guess I should do the same for the polynomial template thing.)
• I cannot see the "fast nullspace"

[burcin]

Attachment: trac_8939-matrix_template-4.4.2-part2.patch.gz

address referee comments

[burcin]

comment:5

Replying to @malb:

The patch looks good. However, I'd prefer to have a bit more documentation.

• I think there should be doctests in fmpz_poly_linkage.pxi. I know our policy does not require it, but it seems like a good pplace to put some

Done. I added a new file sage/libs/flint/fmpz_poly_linkage_tests.pyx with python functions wrapping the celement_*() functions. I don't know how to test the celement_{construct,destruct}() functions, so they are omitted.

• It would be nice to write a bit about how all the files (templates etc.) relate to each other, e.g. some documentation in matrix_dense_template.pxi which makes it explains a bit how to use it. (I guess I should do the same for the polynomial template thing.)

Done, with a brief description at the beginning of matrix_dense_template.pxi.

• I cannot see the "fast nullspace"

This will be on a different ticket, when I get around to cleaning it up...