-
-
Notifications
You must be signed in to change notification settings - Fork 688
sparse strategies for composite elliptic-curve isogenies #34965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sparse strategies for composite elliptic-curve isogenies #34965
Conversation
Codecov ReportBase: 88.58% // Head: 88.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #34965 +/- ##
===========================================
- Coverage 88.58% 88.58% -0.01%
===========================================
Files 2140 2140
Lines 396961 396964 +3
===========================================
- Hits 351655 351643 -12
- Misses 45306 45321 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
LGTM but I think @defeo should look at it too. |
b52a631 to
08a832b
Compare
a5dd7c6 to
810208a
Compare
810208a to
6dd2b93
Compare
6dd2b93 to
d319082
Compare
d319082 to
e3d17c3
Compare
|
Otherwise, LGTM. |
e3d17c3 to
17a5859
Compare
|
Documentation preview for this PR (built with commit 17a5859) is ready! 🎉 |
kwankyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
|
I wonder why |
|
Thanks to both of you for reviewing this! The function is hidden because of the leading underscore; it's a common Python convention for internal functions. |
I know. I wondered why it is an internal function. But never mind now. I won't. |
Fixes #34239.