Skip to content

Issue #34949: sage.{categories,matrix,structure}: Replace imports from sage.*.all for namespace packages #35012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 24, 2023
Merged

Issue #34949: sage.{categories,matrix,structure}: Replace imports from sage.*.all for namespace packages #35012

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a14d662
sage -fiximports src/sage/{categories,matrix,structure}
alexchandler100 Jan 29, 2023
9911481
src/sage/{categories,matrix,structure}: Manual fixes to imports
alexchandler100 Jan 29, 2023
01cded9
src/sage/structure/element.pyx: Fix up
mkoeppe Jan 30, 2023
6203202
sage.matrix: Consolidate imports from the same module
mkoeppe Jan 30, 2023
b88eb84
Merge remote-tracking branch 'upstream/develop' into t/34949/sage__ca…
mkoeppe Feb 7, 2023
6efb63e
src/sage/structure/element.pyx: Fix placement of # optional tag
mkoeppe Feb 8, 2023
a6b3c65
src/sage/structure/element.pyx: Fix placement of remaining # optional…
mkoeppe Feb 8, 2023
eaffa99
Fix placement of remaining '# optional - sage.misc.cython' tags
mkoeppe Feb 8, 2023
e02e213
src/sage/structure/element.pyx: Restore import of lazy_attribute in c…
mkoeppe Feb 8, 2023
25783a4
Replace relative imports by absolute imports because pytest
mkoeppe Feb 16, 2023
d905cc3
Merge remote-tracking branch 'upstream/develop' into t/34949/sage__ca…
mkoeppe Feb 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src/sage/structure/element.pyx: Fix up
  • Loading branch information
Matthias Koeppe committed Jan 30, 2023
commit 01cded97cb2a4cdbfef84f369a6217d8917edc8f
4 changes: 2 additions & 2 deletions src/sage/structure/element.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4053,7 +4053,7 @@ cdef class PrincipalIdealDomainElement(DedekindDomainElement):
right = py_scalar_to_element(right)
if not isinstance(right, Element):
right = right.sage()
from sage.arith.misc import GCD as gcd
if not ((<Element>right)._parent is self._parent):
from sage.arith.misc import GCD as gcd
return coercion_model.bin_op(self, right, gcd)
return self._gcd(right)
Expand Down Expand Up @@ -4087,7 +4087,7 @@ cdef class PrincipalIdealDomainElement(DedekindDomainElement):
right = py_scalar_to_element(right)
if not isinstance(right, Element):
right = right.sage()
from sage.arith.functions import lcm
if not ((<Element>right)._parent is self._parent):
from sage.arith.functions import lcm
return coercion_model.bin_op(self, right, lcm)
return self._lcm(right)
Expand Down