-
-
Notifications
You must be signed in to change notification settings - Fork 688
Upgrade scipy to 1.10.1 #35082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade scipy to 1.10.1 #35082
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #35082 +/- ##
===========================================
- Coverage 88.59% 88.58% -0.02%
===========================================
Files 2140 2140
Lines 396998 396998
===========================================
- Hits 351740 351683 -57
- Misses 45258 45315 +57 see 25 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
doctest failure in |
|
Looks good to me and scipy 1.10.0 works fine here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
Let me know if that was an abuse of the workflow. |
|
Starting a review and approving the changes is exactly the right procedure. Thanks! |
|
It wouldn't be the first time that numpy or scipy gives us a small change in a minor release, so I am doing some more checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot see any problem with it. Once I removed all the warnings I got from matplotlib 3.7.0.
|
Thanks! Also works without problems on macOS |
|
Doesn't build on OSX for me: http://build.sagemath.org/#/builders/54/builds/16 |
|
I think this is misconfigured on your buildbot. Do you set ARCHFLAGS to the empty string? |
|
Anyway I'm working on a PR for meson-python that makes this more robust |
|
Documentation preview for this PR is ready! 🎉 |
📚 Description
The upgrade also includes upgrades of
meson,meson_python, andpythran.Closes #34842
📝 Checklist
⌛ Dependencies