Skip to content

Upgrade polymake to 4.9 #35085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 19, 2023
Merged

Upgrade polymake to 4.9 #35085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8cf537
build/pkgs/polymake: Update to 4.8
mkoeppe Dec 21, 2022
62dae33
build/pkgs/polymake/spkg-install.in: Add -I directives to CXXFLAGS
mkoeppe Dec 21, 2022
da792af
build/pkgs/polymake/dependencies: Add lrslib (needed for sympol)
mkoeppe Dec 22, 2022
0489c98
build/pkgs/polymake: Update to 4.9
mkoeppe Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build/pkgs/polymake/checksums.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
tarball=polymake-VERSION-minimal.tar.bz2
sha1=a3903ef9438388e56a76cb04918c1fe9b2e2b563
md5=9a451d56cfe8c6138b91558d6d369dbe
cksum=1195315956
sha1=e34a9cb83a831b4b058e0803a606f29ff940a4e2
md5=2118f0cae2f512b994bbc72552966bb9
cksum=2954910267
upstream_url=https://polymake.org/lib/exe/fetch.php/download/polymake-VERSION-minimal.tar.bz2
2 changes: 1 addition & 1 deletion build/pkgs/polymake/dependencies
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$(MP_LIBRARY) bliss cddlib normaliz perl_term_readline_gnu ppl perl_cpan_polymake_prereq libxml2 | ninja_build
$(MP_LIBRARY) bliss cddlib normaliz perl_term_readline_gnu ppl perl_cpan_polymake_prereq libxml2 lrslib | ninja_build

----------
All lines of this file are ignored except the first.
2 changes: 1 addition & 1 deletion build/pkgs/polymake/package-version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4.7
4.9
4 changes: 4 additions & 0 deletions build/pkgs/polymake/spkg-install.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ if [ -x $SAGE_LOCAL/bin/lrs1 ]; then
more_configure_options="$more_configure_options --with-lrs=$SAGE_LOCAL"
fi

# Put these includes on the front, to avoid shadowing by installed headers
# from a previous version. (polymake 4.8 puts these includes to the end.)
export CXXFLAGS="-I$(pwd)/include/core-wrappers -I$(pwd)/include/core $CXXFLAGS"
Copy link
Contributor

@kliem kliem Feb 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you find out, that you need to do this?

Copy link
Contributor Author

@mkoeppe mkoeppe Feb 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an error when I tried the 4.8 upgrade, and I stared long enough at the command lines...

Copy link
Contributor

@kliem kliem Feb 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, there really is no reference to this solution.


./configure --without-java \
--without-javaview \
--without-soplex \
Expand Down