Skip to content

construct AdditiveAbelianGroupWrapper from (not necessarily independent) generating set #35270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 1, 2023
Merged

construct AdditiveAbelianGroupWrapper from (not necessarily independent) generating set #35270

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aad2518
implement AdditiveAbelianGroupWrapper.from_generators()
yyyyx4 Dec 20, 2022
40770f6
first batch of reviewer comments
yyyyx4 Mar 15, 2023
0237e7e
convert input checks from assertions to ifs; merge min() into loop
yyyyx4 Mar 16, 2023
c57f264
add INPUT/OUTPUT to docstring
yyyyx4 Mar 16, 2023
434da5d
deduplicate assertion
yyyyx4 Mar 16, 2023
33f5f73
really check for negative; simplify logic for minimal nonzero entry
yyyyx4 Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
really check for negative; simplify logic for minimal nonzero entry
  • Loading branch information
@yyyyx4
yyyyx4 committed Mar 17, 2023
commit 33f5f73abae46cd28525f0d0da816eb18a98755c
13 changes: 9 additions & 4 deletions src/sage/groups/additive_abelian/additive_abelian_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,18 +670,23 @@ def _expand_basis_pgroup(p, alphas, vals, beta, h, rel):
# assert not sum(r*a for r,a in zip(rel, alphas+[beta]))
# assert all(a.order() == p**v for a,v in zip(alphas,vals))

if rel[-1] < 0:
raise ValueError('rel must have nonnegative entries')

# step 1
min_r = rel[-1]
min_r = rel[-1] or float('inf')
for i in range(k-1):
if not rel[i]:
continue
if rel[i] < 0:
raise ValueError('rel must have nonnegative entries')
q = rel[i].p_primary_part(p)
alphas[i] *= rel[i] // q
rel[i] = q
if not min_r or q < min_r:
if q < min_r:
min_r = q
if min_r <= 0:
raise ValueError('rel must have nonnegative entries and at least one nonzero entry')
if min_r == float('inf'):
raise ValueError('rel must have at least one nonzero entry')
val_rlast = rel[-1].valuation(p)
# assert rel[-1] == p ** val_rlast
# assert not sum(r*a for r,a in zip(rel, alphas+[beta]))
Expand Down