pkgs/sage-project-cookiecutter
#37541
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 6fd32f4; changes) is ready! 🎉 |
|
Rebased away from #37534 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 18, 2024
sagemathgh-36525: GH Actions: Fix build of macOS x86_64 wheels, build wheels for sagemath-{bliss,coxeter3,mcqd,tdlib} for PyPI <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> Because the GitHub runner `macos-latest` is now Apple Silicon, building x86_64 wheels is broken. We fix this here by using `macos-13` for building x86_64. We speed up the build on Linux by bootstrapping only once in each job, and configuring and building packages of the Sage distribution only once for each Linux platform. Bootstrapping is now done outside of the container, and we configure Sage to use a `--prefix` in a directory mounted from the host, and storing the `config.status`. We add wheels for the optional-extension packages **sagemath-bliss**, ... that can be built on top of the existing modularized distributions. (The packages **sagemath-meataxe** and **sagemath-sirocco** have to wait for **sagemath-modules** to become available.) Tests at https://github.com/mkoeppe/sage/actions/workflows/dist.yml: - Successful run at https://github.com/mkoeppe/sage/actions/runs/9100668826 (the failure in release_dist is unrelated) Follow-up: - sagemath#37541, refactor as reusable GH Actions workflow -- for use by cysignals, cypari2, pplpy etc. Part of: - sagemath#31251 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - Depends on sagemath#36521 - Depends on sagemath#37503 (merged here) <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36525 Reported by: Matthias Köppe Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 24, 2024
sagemathgh-36525: GH Actions: Fix build of macOS x86_64 wheels, build wheels for sagemath-{bliss,coxeter3,mcqd,tdlib} for PyPI <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> Because the GitHub runner `macos-latest` is now Apple Silicon, building x86_64 wheels is broken. We fix this here by using `macos-13` for building x86_64. We speed up the build on Linux by bootstrapping only once in each job, and configuring and building packages of the Sage distribution only once for each Linux platform. Bootstrapping is now done outside of the container, and we configure Sage to use a `--prefix` in a directory mounted from the host, and storing the `config.status`. We add wheels for the optional-extension packages **sagemath-bliss**, ... that can be built on top of the existing modularized distributions. (The packages **sagemath-meataxe** and **sagemath-sirocco** have to wait for **sagemath-modules** to become available.) Tests at https://github.com/mkoeppe/sage/actions/workflows/dist.yml: - Successful run at https://github.com/mkoeppe/sage/actions/runs/9100668826 (the failure in release_dist is unrelated) Follow-up: - sagemath#37541, refactor as reusable GH Actions workflow -- for use by cysignals, cypari2, pplpy etc. Part of: - sagemath#31251 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - Depends on sagemath#36521 - Depends on sagemath#37503 (merged here) <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36525 Reported by: Matthias Köppe Reviewer(s):
added 14 commits
November 9, 2024 17:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cookiecuttertemplates for several kinds of Sage projects / packages.Updatable using https://cruft.github.io/cruft/
Resolves #34286
📝 Checklist
⌛ Dependencies