Skip to content

Deprecate is_Fan, is_NefPartition, is_PointCollection, is_ToricLattice, is_ToricLatticeElement, is_ToricLatticeQuotient #38126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2024
Merged

Deprecate is_Fan, is_NefPartition, is_PointCollection, is_ToricLattice, is_ToricLatticeElement, is_ToricLatticeQuotient #38126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f26975f
for a in "CLASS='ToricLatticeElement|PointCollection|NefPartition';SU…
mkoeppe Jun 1, 2024
39313d0
Deprecate is_Fan
mkoeppe Jun 1, 2024
72ca0a3
Deprecations
mkoeppe Jun 1, 2024
18e9f71
Merge remote-tracking branch 'upstream/develop' into is_Fan_deprecation
mkoeppe Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Deprecate is_Fan
  • Loading branch information
Matthias Koeppe committed Jun 1, 2024
commit 39313d0f8fb586153d8abeba2e4113c45b3913f2
4 changes: 4 additions & 0 deletions src/sage/geometry/fan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,10 @@ def is_Fan(x) -> bool:
sage: is_Fan(fan) # needs palp
True
"""
from sage.misc.superseded import deprecation
deprecation(38126,
"The function is_Fan is deprecated; "
"use 'isinstance(..., RationalPolyhedralFan)' instead.")
return isinstance(x, RationalPolyhedralFan)


Expand Down
6 changes: 3 additions & 3 deletions src/sage/geometry/fan_morphism.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@

from sage.categories.homset import Hom
from sage.geometry.cone import Cone
from sage.geometry.fan import Fan, is_Fan
from sage.geometry.fan import Fan, RationalPolyhedralFan
from sage.matrix.constructor import matrix
from sage.matrix.special import identity_matrix
from sage.structure.element import is_Matrix
Expand Down Expand Up @@ -270,8 +270,8 @@ def __init__(self, morphism, domain_fan,
Codomain fan: Rational polyhedral fan in 2-d lattice N
sage: TestSuite(fm).run(skip="_test_category")
"""
assert is_Fan(domain_fan)
if is_Fan(codomain):
assert isinstance(domain_fan, RationalPolyhedralFan)
if isinstance(codomain, RationalPolyhedralFan):
codomain, codomain_fan = codomain.lattice(), codomain
else:
codomain_fan = None
Expand Down