Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip preview check if no preview failed
  • Loading branch information
vincentmacri committed Dec 7, 2025
commit 2f00d983c68a0775d3f0d6ebc23009aec6442955
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
run: uv run --frozen --only-group lint -- ruff check --output-format github --config .github/workflows/ruff.toml --no-preview

- name: Code style check with ruff (preview)
if: (success() || failure()) && steps.deps.outcome == 'success'
if: success()
run: uv run --frozen --only-group lint -- ruff check --output-format github --config .github/workflows/ruff.toml --preview

- name: Code style check with relint
Expand Down
16 changes: 8 additions & 8 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -251,14 +251,14 @@ exclude = [
# disagree with them or because following them is not currently practical.
ignore = [
"E501", # Line too long - hard to avoid in doctests, and better handled by black.
"E741", "E743", # Variable/function names I, O, l - common in math, and not an issue for most monospace fonts
"PLC2401", # Non-ASCII variables - we deliberately use Greek letters (albeit sparingly)

# The following rules are good in spirit but require some common sense, better enforced through code review.
"PLR09", # Rules about code complexity - better enforced through code review process.
"PLR1714", # Repeated equality comparison - too picky when only doing a couple comparisons.
"PLR2004", # Comparison to magic values - better enforced through code review process.
"PLW1641", # __eq__ without __hash__ - implementations of equivalence classes may have a well-defined notion of equality without a well-defined canonical representation that can be used to compute a hash
# "E741", "E743", # Variable/function names I, O, l - common in math, and not an issue for most monospace fonts
# "PLC2401", # Non-ASCII variables - we deliberately use Greek letters (albeit sparingly)
#
# # The following rules are good in spirit but require some common sense, better enforced through code review.
# "PLR09", # Rules about code complexity - better enforced through code review process.
# "PLR1714", # Repeated equality comparison - too picky when only doing a couple comparisons.
# "PLR2004", # Comparison to magic values - better enforced through code review process.
# "PLW1641", # __eq__ without __hash__ - implementations of equivalence classes may have a well-defined notion of equality without a well-defined canonical representation that can be used to compute a hash

# Imports at top-level of file - we can't follow this because we intentionally defer imports for various reasons.
# maybe once we can use PEP 810 this can be fixed.
Expand Down