Skip to content

Fix the wrong vertices number of Cayley graphs of free groups #41274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cxzhong wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Fix the wrong vertices number of Cayley graphs of free groups #41274

cxzhong wants to merge 16 commits into from

Conversation

@cxzhong
Copy link
Contributor

@cxzhong cxzhong commented Dec 8, 2025 •
edited
Loading

fix #40549
I think the better way is to keep hash method is just for the words. and for ==, we use gap to decide it.
Then rewrite Cayley graph function. It will keep the group elements can be a key/dict.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@cxzhong cxzhong requested a review from tscrim December 8, 2025 12:28
@cxzhong
Remove example code from Cayley graph documentation
3505b17 
Removed example code from the documentation.
@github-actions
Copy link

github-actions bot commented Dec 8, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 76db9ce; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@cxzhong
Copy link
Contributor Author

cxzhong commented Dec 8, 2025 •
edited
Loading

And _hash_ can not return NotImplemented Error. Because some methods regards it as a key in dict

@cxzhong cxzhong closed this Dec 8, 2025
@cxzhong cxzhong deleted the fix-free-group branch December 9, 2025 06:30
@cxzhong cxzhong restored the fix-free-group branch December 9, 2025 08:50
@cxzhong cxzhong reopened this Dec 9, 2025
@cxzhong
Improve as_permutation_group error handling
414dc20 
Added error handling for as_permutation_group method to support subclasses without limit parameter.
@cxzhong
revert
c200c78
@cxzhong
Implement cayley_graph method for Artin groups
d66d049 
Added a method to return the Cayley graph of Artin groups, requiring elements to be specified due to their infinite nature.
@cxzhong
Implement cayley_graph method for braid groups
76db9ce 
Added a method to return the Cayley graph for braid groups, requiring elements to be specified due to their infinite nature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tscrim tscrim Awaiting requested review from tscrim

Assignees

No one assigned

Labels

s: needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cayley graphs of free groups have wrong number of vertices.

1 participant

@cxzhong