fix(signature): Update active parameter to use line and col range #2296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Single check of vim.fn.has('nvim.11.0')
- Relatively verbose implementation for clarity.
- could easily refactor to a single nvim_buf_set_extmark call with only
the variables changed. (I have not tested this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses: #2295
As noted in window.lua nvim 11.0 returns start and end lines for
vim.lsp.util.convert_signature_help_to_markdown_lines. I have implemented a simple logic to handle this. I've tested it locally with a few LSP's and it seems to work without issue. It could be made more concise if you prefer but I felt this approach had good clarity of intent. Pretty minor issue so feel free to implement yourself/another way. Commit notes below.Thanks!