Skip to content

[vizdoom] remove legacy glibc version header hack#364

Merged
Trinkle23897 merged 1 commit into
mainfrom
jiayi/remove-vizdoom-glibc-header
Mar 30, 2026
Merged

[vizdoom] remove legacy glibc version header hack#364
Trinkle23897 merged 1 commit into
mainfrom
jiayi/remove-vizdoom-glibc-header

Conversation

@Trinkle23897
Copy link
Copy Markdown
Collaborator

Summary

  • Problem: ViZDoom still carried a legacy glibc_version_header shim that force-included a glibc 2.17 header into multiple Bazel targets even though the current Linux release flow now targets manylinux_2_28.
  • Scope: Remove the external glibc_version_header repository, delete the local glue files under third_party/glibc_version_header/, and stop injecting that header throughout the ViZDoom third-party BUILD rules. This does not change the current manylinux baseline or broader release policy.
  • Outcome: ViZDoom builds no longer rely on the legacy glibc header hack, and the Bazel graph is smaller and easier to reason about.

This diff removes an obsolete compatibility shim that no longer matches the repo's current Linux wheel baseline.

Technical Details

  • Approach: Delete the glibc_version_header workspace dependency and strip all @glibc_version_header//:glibc_2_17 src/tool references plus -include ...glibc_2_17 copts from the ViZDoom BUILD graph.
  • Code pointers:
    • third_party/vizdoom/vizdoom.BUILD: removes all forced glibc header injection from ViZDoom helper binaries, libraries, and the main vizdoom target.
    • envpool/workspace0.bzl: removes the now-unused external archive for glibc_version_header.
  • Notes: The current release flow already builds Linux wheels in manylinux_2_28, so keeping a separate glibc-2.17 header shim was inconsistent with the actual supported baseline.

Test Plan

Automated

  • buildifier envpool/workspace0.bzl third_party/vizdoom/vizdoom.BUILD: passed
  • bazel build @vizdoom//:zipdir: passed
  • bazel build @vizdoom//:vizdoom: reached the SDL2 rules_foreign_cc build and then failed due to a pre-existing local macOS sandbox issue (cmake: command not found inside the Bazel sandbox), not due to missing glibc_version_header references

Suggested Manual

  • bazel build @vizdoom//:vizdoom in Linux CI or a Linux dev environment with the expected foreign_cc toolchain available: verify the full ViZDoom binary still builds cleanly
  • Release wheel smoke on Linux: verify ViZDoom packaging still works without the removed header shim

@Trinkle23897 Trinkle23897 merged commit 7f35eae into main Mar 30, 2026
10 of 11 checks passed
@Trinkle23897 Trinkle23897 deleted the jiayi/remove-vizdoom-glibc-header branch March 30, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant