[vizdoom] remove legacy glibc version header hack#364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
glibc_version_headershim that force-included aglibc 2.17header into multiple Bazel targets even though the current Linux release flow now targetsmanylinux_2_28.glibc_version_headerrepository, delete the local glue files underthird_party/glibc_version_header/, and stop injecting that header throughout the ViZDoom third-party BUILD rules. This does not change the current manylinux baseline or broader release policy.This diff removes an obsolete compatibility shim that no longer matches the repo's current Linux wheel baseline.
Technical Details
glibc_version_headerworkspace dependency and strip all@glibc_version_header//:glibc_2_17src/tool references plus-include ...glibc_2_17copts from the ViZDoom BUILD graph.third_party/vizdoom/vizdoom.BUILD: removes all forced glibc header injection from ViZDoom helper binaries, libraries, and the mainvizdoomtarget.envpool/workspace0.bzl: removes the now-unused external archive forglibc_version_header.manylinux_2_28, so keeping a separate glibc-2.17 header shim was inconsistent with the actual supported baseline.Test Plan
Automated
buildifier envpool/workspace0.bzl third_party/vizdoom/vizdoom.BUILD: passedbazel build @vizdoom//:zipdir: passedbazel build @vizdoom//:vizdoom: reached the SDL2rules_foreign_ccbuild and then failed due to a pre-existing local macOS sandbox issue (cmake: command not foundinside the Bazel sandbox), not due to missingglibc_version_headerreferencesSuggested Manual
bazel build @vizdoom//:vizdoomin Linux CI or a Linux dev environment with the expected foreign_cc toolchain available: verify the full ViZDoom binary still builds cleanly