[highway] add highway-env support#390
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27f31e8c8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why/Context/Summary
highway-envtask family, including all registered upstream IDs, EnvPool aliases, deterministic reset/step/render behavior, and a doc-only EnvPool-vs-official render comparison.highway_env/Gymnasium usage out of runtime implementation; official envs are only used by tests and doc tooling as an oracle.intersection-multi-agent-v1.Test plan
make ruff py-format: passedmake mypy: passedmake clang-format: passedmake cpplint: passedgit diff --check: passedbazel test --test_output=errors //envpool/highway/...: passed, 5/5 Highway testsmake bazel-test BAZEL_TEST_TARGETS=//envpool:make_testwith sanitized PATH forwarded through Bazelaction_env/host_action_env: passedrgimplementation scan for Python bridge/import patterns: no bridge hitsdocutilsparse ofdocs/env/highway.rst: passed1320x1296, RGB)lint,clang-tidy, and CodeQL: passed on the latest pushed commit