Skip to content

[highway] add highway-env support#390

Merged
Trinkle23897 merged 41 commits into
mainfrom
jiayi/highway-env
Apr 10, 2026
Merged

[highway] add highway-env support#390
Trinkle23897 merged 41 commits into
mainfrom
jiayi/highway-env

Conversation

@Trinkle23897
Copy link
Copy Markdown
Collaborator

@Trinkle23897 Trinkle23897 commented Apr 8, 2026

Why/Context/Summary
  • Add native C++ EnvPool support for the upstream highway-env task family, including all registered upstream IDs, EnvPool aliases, deterministic reset/step/render behavior, and a doc-only EnvPool-vs-official render comparison.
  • Keep official highway_env/Gymnasium usage out of runtime implementation; official envs are only used by tests and doc tooling as an oracle.
  • Tighten official alignment coverage, including longer rollouts, multi-step render checks, intersection and multi-agent cases, plus a TODO for exposing per-player termination for intersection-multi-agent-v1.
Test plan
  • make ruff py-format: passed
  • make mypy: passed
  • make clang-format: passed
  • make cpplint: passed
  • git diff --check: passed
  • bazel test --test_output=errors //envpool/highway/...: passed, 5/5 Highway tests
  • make bazel-test BAZEL_TEST_TARGETS=//envpool:make_test with sanitized PATH forwarded through Bazel action_env / host_action_env: passed
  • rg implementation scan for Python bridge/import patterns: no bridge hits
  • docutils parse of docs/env/highway.rst: passed
  • render montage regenerated and checked as PNG (1320x1296, RGB)
  • GitHub CI lint, clang-tidy, and CodeQL: passed on the latest pushed commit

Comment thread envpool/entry.py
Comment thread envpool/highway/highway_align_test.py Fixed
Comment thread envpool/highway/highway_align_test.py Fixed
Comment thread envpool/highway/highway_deterministic_test.py Fixed
Comment thread envpool/highway/highway_official_coverage_test.py Fixed
Comment thread envpool/highway/highway_official_coverage_test.py Fixed
Comment thread envpool/highway/highway_render_test.py Fixed
Comment thread envpool/highway/highway_render_test.py Fixed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 27f31e8c8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread envpool/highway/official_bridge.h Outdated
Comment thread envpool/highway/highway_deterministic_test.py Fixed
Comment thread envpool/highway/highway_align_test.py Fixed
Comment thread envpool/highway/highway_official_coverage_test.py Fixed
Comment thread envpool/highway/highway_render_test.py Fixed
Comment thread envpool/highway/highway_official_align_test.py Fixed
@Trinkle23897 Trinkle23897 merged commit df065e6 into main Apr 10, 2026
13 checks passed
@Trinkle23897 Trinkle23897 deleted the jiayi/highway-env branch April 10, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant