Skip to content

Add a context manager to Client like in AsyncClient #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2025
Merged

Add a context manager to Client like in AsyncClient #1483

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d1c100
Add a context manager to Client like in AsyncClient
sanders41 Oct 18, 2025
790653c
Refactor client fixture to use context manager
sanders41 Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Refactor client fixture to use context manager
  • Loading branch information
@sanders41
sanders41 authored Oct 18, 2025
commit 790653ca0aa0febdc7d519217ac0c9315ec89ea1
3 changes: 2 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ async def async_client_with_plugins(base_url, ssl_verify):

@pytest.fixture(scope="session")
def client(base_url, ssl_verify):
yield Client(base_url, MASTER_KEY, verify=ssl_verify)
with Client(base_url, MASTER_KEY, verify=ssl_verify) as client:
yield client


@pytest.fixture(scope="session")
Expand Down