Skip to content

Use a more recent version of Carbon for our benchmarks #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nex3 merged 2 commits into from
Jan 6, 2022
Merged

Use a more recent version of Carbon for our benchmarks #1573

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fa365a
Use a more recent version of Carbon for our benchmarks
nex3 Dec 15, 2021
a6c3540
Update performance numbers
nex3 Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use a more recent version of Carbon for our benchmarks 
See #1534
  • Loading branch information
@nex3
nex3 committed Jan 5, 2022
commit 4fa365adcadcfd613276fc83a3cc86caa0de0843
7 changes: 2 additions & 5 deletions tool/grind/benchmark.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,10 @@ Future<void> benchmarkGenerate() async {
File("${sources.path}/duomo.scss")
.writeAsStringSync("@import '../duomo/scripts/duomo.scss'");

// Note: This version only supports Node Sass 5.x, which only supports up to
// Node 14.x. Once there's a version that support Node Sass 6.x, we should use
// that instead.
var carbon = cloneOrCheckout(
"https://github.com/carbon-design-system/ibm-cloud-cognitive",
"@carbon/ibm-cloud-cognitive@0.93.2");
await runAsync("npm", arguments: ["install"], workingDirectory: carbon);
"@carbon/ibm-cloud-cognitive@1.0.0-rc.0");
await runAsync("yarn", arguments: ["install"], workingDirectory: carbon);
File("${sources.path}/carbon.scss")
.writeAsStringSync("@import '../ibm-cloud-cognitive/packages/"
"cloud-cognitive/src/index-without-carbon-released-only'");
Expand Down