Skip to content

Pass undefined span instead of null to Logger.warn() in JS #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nex3 merged 1 commit into from
Jan 5, 2022
Merged

Pass undefined span instead of null to Logger.warn() in JS #1586

nex3 merged 1 commit into from
Jan 5, 2022

Conversation

@nex3
Copy link
Contributor

@nex3 nex3 commented Jan 4, 2022

@nex3 nex3 requested a review from jathak January 4, 2022 22:33
@nex3 nex3 force-pushed the undefined-span branch 2 times, most recently from d2fc580 to cb894ed Compare January 4, 2022 22:41
@nex3 nex3 merged commit 6bf9853 into main Jan 5, 2022
@nex3 nex3 deleted the undefined-span branch January 5, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jathak jathak jathak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nex3 @jathak