Skip to content

Only claim "package:" URLs are unsupported on Node #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nex3 merged 4 commits into from
Apr 4, 2019
Merged

Only claim "package:" URLs are unsupported on Node #637

nex3 merged 4 commits into from
Apr 4, 2019
+43 −20

Conversation

@nex3
Copy link
Contributor

@nex3 nex3 commented Apr 3, 2019

Closes #630

@nex3 nex3 requested a review from jathak April 3, 2019 08:18
@jathak
Copy link
Member

jathak commented Apr 3, 2019

Looks like lib/src/visitor/evaluate.dart needs to be updated

@nex3
Copy link
Contributor Author

nex3 commented Apr 3, 2019

Looks like lib/src/visitor/evaluate.dart needs to be updated

Done.

@nex3 nex3 merged commit 495c6f3 into master Apr 4, 2019
@nex3 nex3 deleted the package-url-error branch April 4, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jathak jathak jathak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nex3 @jathak