Skip to content

Fixing a bug for function definition #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apanichella wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing a bug for function definition #623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixing a bug for function definition 
The function defintion should start one posiiton after the end of the modifier.
Given a function "function method() onlyOwner {...}', the current version of the return the definition "r{...}" instead of "{...}". I notice the same error happens when a function uses a modifier: the last character of the modifier is added to the  parsed definiton.

This commit fixes the bug.
  • Loading branch information
@apanichella
apanichella authored Mar 26, 2021
commit a5440d59059e1856de342dc5eb58c79a06254939
4 changes: 2 additions & 2 deletions lib/registrar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ class Registrar {
// which contains an open curly brace. Skip ahead...
if (expression.modifiers && expression.modifiers.length){
for (let modifier of expression.modifiers ){
if (modifier.range[1] > start){
start = modifier.range[1];
if (modifier.range[1]+1 > start){
start = modifier.range[1]+1;
}
}
} else {
Expand Down