Skip to content

Add extendConfig logic for hardhat-viem plugin #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgewecke merged 4 commits into from
Apr 5, 2024
Merged

Add extendConfig logic for hardhat-viem plugin #883

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e82016c
Add extendConfig logic for hardhat-viem plugin
cgewecke Apr 5, 2024
4f32cfd
Fix spacing
cgewecke Apr 5, 2024
a8f5b0d
Add hardhat network config to integration test
cgewecke Apr 5, 2024
ac4a0b3
Fix network clone in extendConfig
cgewecke Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix spacing
  • Loading branch information
@cgewecke
cgewecke committed Apr 5, 2024
commit 4f32cfd490f3f8b356f8be16136781c18988e8c7
3 changes: 2 additions & 1 deletion plugins/resources/nomiclabs.ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ class PluginUI extends UI {
`${c.red('the path you specified for it is wrong.')}`,

'tests-fail': `${x} ${c.bold(args[0])} ${c.red('test(s) failed under coverage.')}`,

'hardhat-viem': "'hardhat-viem' requires an environment variable to be set when used with the solidity-coverage plugin"
}

Expand All @@ -96,4 +97,4 @@ class PluginUI extends UI {

}

module.exports = PluginUI;
module.exports = PluginUI;
2 changes: 1 addition & 1 deletion test/integration/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ describe('Hardhat Plugin: error cases', function() {
} catch(err){
assert(
err.message.includes('requires an environment variable'),
`Should notify when mocha parallel flag is set:: ${err.message}`
`Should error when viem plugin is used without env variable:: ${err.message}`
);
}

Expand Down