Quiet core/test "close multiple times" test #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! |
As folks may know better than I, in uTest individual tests are documented are documented as returning a value, which can itself be validated. If the return value is not Unit, it is printed out. Before this PR, the "close multiple times" test was returning the value of an object, which was getting printed out and adding something to the log which needed to be figured out as safe. This PR causes that test to be silent, thereby reducing clutter. Agreed, this is a nit. I think it is worth fixing because the present file may serve as a cut & paste template for additional tests as they are added. If I can not fix something useful, I can at least remove a small wart.
Before the timer was timing out after the test was declared successful. To preserve the semantics of utest a async test need to return the last Future to be completed as result
lolgab
force-pushed
the
d1/lee49/DevoHdd1/sn_native-loop/Devo_1/PR_core_test_SilenceOneTest_2020-07-27
branch
from
adf3686 to
3a24bd5
Compare
LeeTibbert
deleted the
d1/lee49/DevoHdd1/sn_native-loop/Devo_1/PR_core_test_SilenceOneTest_2020-07-27
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As folks may know better than I, in uTest individual tests are documented
are documented as returning a value, which can itself be validated.
If the return value is not Unit, it is printed out.
Before this PR, the "close multiple times" test was returning the
value of an object, which was getting printed out and adding
something to the log which needed to be figured out as safe.
This PR causes that test to be silent, thereby reducing clutter.
Agreed, this is a nit. I think it is worth fixing because the present
file may serve as a cut & paste template for additional tests as they
are added.
If I can not fix something useful, I can at least remove a small wart.