Skip to content

Conversation

@rjolly
Copy link
Contributor

@rjolly rjolly commented Feb 21, 2013

Usage:

scala/bin/jarlister -o scala-library-listed.jar scala/lib/scala-library.jar

jrunscript -classpath scala/lib/scala-compiler.jar:scala/lib/scala-reflect.jar:scala-library-listed.jar -l scala

@ghost ghost assigned paulp Feb 21, 2013
@JamesIry
Copy link
Contributor

review @paulp

@JamesIry
Copy link
Contributor

PLS SYNCH

@scala-jenkins
Copy link

(kitty-note-to-self: ignore 13955366)
🐱 Synchronaising! 🙏

@JamesIry
Copy link
Contributor

PLS REBUILD ALL

@scala-jenkins
Copy link

(kitty-note-to-self: ignore 14186715)
🐱 Roger! Rebuilding pr-rangepos-per-commit, pr-checkin-per-commit for 9966d1d. 🚨

@JamesIry
Copy link
Contributor

JamesIry commented Mar 1, 2013

ping @adriaanm The flag under issues shows this has been tested but it's not updated here

ping @paulp for review

@adriaanm
Copy link
Contributor

adriaanm commented Mar 3, 2013

BUILDLOG?

@scala-jenkins
Copy link

(kitty-note-to-self: ignore 14358624)
pr-rangepos-per-commit:

  • 9966d1d: pending: OK Took 46 min. (But waiting for pr-checkin-per-commit), pending: OK Took 66 min. (But waiting for pr-checkin-per-commit), pending: started., pending: started.

pr-checkin-per-commit:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a copyright/author header

@adriaanm
Copy link
Contributor

adriaanm commented Mar 5, 2013

This is great stuff, thanks @rjolly! (I apologize for not having gotten to this faster.)

I'd like to see it split up in several commits, so that if something breaks (one never knows) we can revert more selectively.

How about the following breakdown:

  • reflect.io improvements
  • jarlister (but not used in build yet)
  • use jarlister in build
  • actual JSR-223 implementation

Also, review by @jsuereth for build/osgi-related changes.

rjolly added 4 commits March 5, 2013 20:04
Part 1 : reflect.io improvements
Part 2 : jarlister (but not used in build yet)
Part 3 : use jarlister in build
Part 4 : actual JSR-223 implementation
@rjolly rjolly closed this Mar 6, 2013
@JamesIry
Copy link
Contributor

JamesIry commented Mar 6, 2013

subsumed by #2206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants