[indylambda] Improve test coverage #4609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding tests for the selective use of boxing bridge methods and to show that specialization is not subverted by indylambda. Other aspects of indylambda are tested by tests like: - run/lambda-serialization.scala - run/indylambda-boxing When those tests were written, they only tested the old backend. However, now that we have Java 8 and the new backend avaialble by default to partest, they provide the intended coverage.
Member
Author
|
Review by @SethTisue or @lrytz |
Member
|
see also #4603 |
Member
There was a problem hiding this comment.
You need some more boilerplate: the class needs to extend ClearAfterClass, and ClearAfterClass.stateToClear needs to be set. Maybe this can be improved..
class IndyLambdaTest extends ClearAfterClass {
ClearAfterClass.stateToClear = IndyLambdaTest
...
Member
|
otherwise, LGTM |
Contributor
|
(admin note: please don't start your comment with LGTM until it's actually good to merge -- at some point the bot will start merging PRs as soon as the reviewer signs off, so may as well get into this habit now) |
Contributor
|
I'm going to push this to M3, since all other M2 PRs have been merged and this can wait. |
- Add requisite boilerplate for test cleanup to IndyLambdaTest - ... and to the spot where I copy/pasted the wrong code from - Fix comment.
Member
Author
|
@lrytz I've addressed your comments. |
Member
|
LGTM |
lrytz
added a commit
that referenced
this pull request
Jul 9, 2015
[indylambda] Improve test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for the selective use of boxing bridge methods
and to show that specialization is not subverted by indylambda.
Other aspects of indylambda are tested by tests like:
When those tests were written, they only tested the old backend.
However, now that we have Java 8 and the new backend avaialble
by default to partest, they provide the intended coverage.