Merged
Conversation
Member
|
why remove comments? |
Contributor
Author
My code minifier automatically removes them, I can add them back if you'd like?
|
Member
Yes please — the comments have value. |
Contributor
Author
|
Sure, I'll add them back later today or tomorrow. I've also fixed my minifier settings, sorry. |
Contributor
Author
|
Comments have been added, @SethTisue, would you like me to squash? |
jchyb
requested changes
Apr 16, 2024
Contributor
jchyb
left a comment
jchyb
left a comment
There was a problem hiding this comment.
Sorry for the long wait. The changes look good, I just have a few nitpicks.
Contributor
Author
No problem! Take your time! |
WojciechMazur
pushed a commit
to WojciechMazur/dotty
that referenced
this pull request
May 6, 2024
This Pull Request optimizes the functions used in `/docs/_spec/public/scripts/main.js`. ## Changes made: 1. `currentChapter()` function was simplified using `split()` and `pop()` instead of `lastIndexOf()` and `substring()`. 2. Used template literals for string interpolation. 3. Simplified the `heading` function by reducing repetitive code and improving readability. 4. Changed `.removeClass()` and `.addClass()` to `.toggleClass()` for toggling the class based on condition. 5. General cleanup and optimization for better readability and performance.
WojciechMazur
pushed a commit
that referenced
this pull request
Jul 6, 2024
This Pull Request optimizes the functions used in `/docs/_spec/public/scripts/main.js`. ## Changes made: 1. `currentChapter()` function was simplified using `split()` and `pop()` instead of `lastIndexOf()` and `substring()`. 2. Used template literals for string interpolation. 3. Simplified the `heading` function by reducing repetitive code and improving readability. 4. Changed `.removeClass()` and `.addClass()` to `.toggleClass()` for toggling the class based on condition. 5. General cleanup and optimization for better readability and performance. [Cherry-picked 6d29951]
WojciechMazur
added a commit
that referenced
this pull request
Jul 6, 2024
Backports #20093 to the LTS branch. PR submitted by the release tooling. [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request optimizes the functions used in
/docs/_spec/public/scripts/main.js.Changes made:
currentChapter()function was simplified usingsplit()andpop()instead oflastIndexOf()andsubstring().headingfunction by reducing repetitive code and improving readability..removeClass()and.addClass()to.toggleClass()for toggling the class based on condition.