Disallow some opaque type aliases in match type patterns#20913
Draft
odersky wants to merge 2 commits intoscala:mainfrom
Draft
Disallow some opaque type aliases in match type patterns#20913odersky wants to merge 2 commits intoscala:mainfrom
odersky wants to merge 2 commits intoscala:mainfrom
Conversation
Contributor
Author
|
This should give some protection against using opaque types in match type patterns improperly. |
odersky
force-pushed
the
change-opaque-matchtypes-1
branch
from
fa8d00b to
07ac3ed
Compare
odersky
force-pushed
the
change-opaque-matchtypes-1
branch
from
07ac3ed to
4d71bb4
Compare
Contributor
Author
|
This was a left-over from last summer's named tuple work. |
Disallow opaque type aliases in match type patterns in scopes where the alias is visible.
Gedochao
force-pushed
the
change-opaque-matchtypes-1
branch
from
4d71bb4 to
cc5182c
Compare
Contributor
|
Rebased on the latest main. |
Gedochao
added
the
stat: stale PR
Contributor
Author
|
Yes, I think this is still relevant. We should try to get this in, since it prevents an unsoundness (which was encountered in a previous NamedTuple design). |
Contributor
|
It seems tests are failing after rebase. |
Gedochao
removed
the
stat: stale PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disallow opaque type aliases in match type patterns in scopes where the alias is visible.