Implement SIP 57 - add runtimeChecked method and annotation#20987
Merged
bishabosha merged 2 commits intoscala:mainfrom Jul 24, 2024
Merged
Implement SIP 57 - add runtimeChecked method and annotation#20987bishabosha merged 2 commits intoscala:mainfrom
bishabosha merged 2 commits intoscala:mainfrom
Conversation
bishabosha
force-pushed
the
sip-57-unchecked-annot
branch
from
677560c to
5cb3301
Compare
Member
Author
|
For the future: once the definition is stabilised, we can deprecate And also later possibly a language mode could introduce that refutable pattern bindings become an error? |
bishabosha
force-pushed
the
sip-57-unchecked-annot
branch
from
5cb3301 to
9a866c2
Compare
bishabosha
force-pushed
the
sip-57-unchecked-annot
branch
from
9a866c2 to
853920d
Compare
bishabosha
force-pushed
the
sip-57-unchecked-annot
branch
from
853920d to
e8f9812
Compare
bishabosha
force-pushed
the
sip-57-unchecked-annot
branch
from
e8f9812 to
d29ec53
Compare
Member
Author
|
@Gedochao how can I get this reviewed? |
odersky
requested changes
Jul 19, 2024
Contributor
odersky
left a comment
odersky
left a comment
There was a problem hiding this comment.
I left some suggestions for the doc page. Otherwise LGTM.
odersky
approved these changes
Jul 19, 2024
improve documentation based on suggestions Co-authored-by: odersky <odersky@gmail.com>
bishabosha
force-pushed
the
sip-57-unchecked-annot
branch
from
fc54f16 to
5595bdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://docs.scala-lang.org/sips/replace-nonsensical-unchecked-annotation.html
Also this doesn't change synthetic code that is generated to use
@unchecked, or make@uncheckedmeaningless for this use case - this should probably come at a later stage after the definition is no longer experimentalfixes #21012