fix: Only implement a deferred given in a class if its parent won't implement it#21206
Merged
odersky merged 1 commit intoscala:mainfrom Aug 1, 2024
Merged
fix: Only implement a deferred given in a class if its parent won't implement it#21206odersky merged 1 commit intoscala:mainfrom
odersky merged 1 commit intoscala:mainfrom
Conversation
odersky
reviewed
Jul 23, 2024
Contributor
odersky
left a comment
odersky
left a comment
There was a problem hiding this comment.
I am not sure that's the right fix. Should we not simply inherit the definition in the superclass?
Member
Author
|
Oooh, right. Of course, simply not generating this member in the child class should be way better, I will try to do that. |
Contributor
|
I think the logic should be that we implement a deferred given from trait T in class C if
|
KacperFKorban
force-pushed
the
fix-i21189
branch
from
50dc7b5 to
532c287
Compare
KacperFKorban
changed the title
hamzaremmal
added a commit
to hamzaremmal/scala3
that referenced
this pull request
Aug 2, 2024
hamzaremmal
added a commit
that referenced
this pull request
Aug 2, 2024
WojciechMazur
pushed a commit
that referenced
this pull request
Aug 28, 2024
[Cherry-picked 6837445]
WojciechMazur
added a commit
that referenced
this pull request
Aug 28, 2024
Backports #21316 to the 3.5.2 branch. PR submitted by the release tooling. [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be possible to extend a class that inherits a deferred given, so a generated given implementation should not be final.
closes #21189