You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is an updated version of #20424, which fixes a bug in the global initialization checker such that when accessing global object through full path, the checker immediately analyzes the initialization code of the corresponding object.
@liufengyun@olhotak test_scala2_library_tasty shows the extra warnings that we have seen have when analyzing with scala2 library tasty. The initialization cycle object Predef -> package object scala -> object IndexedSeq -> object Vector -> object Predef should be already fixed when using the latest version of scala2-library-tasty. Cyclic initialization: object Predef -> object Manifest -> object ManifestFactory -> object Predef should be fixed after we merge #21523. I think it's safe to merge this PR, and possibly conclude issue #18882.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an updated version of #20424, which fixes a bug in the global initialization checker such that when accessing global object through full path, the checker immediately analyzes the initialization code of the corresponding object.
[test_scala2_library_tasty]