Skip to content

Conversation

@lihaoyi
Copy link
Contributor

@lihaoyi lihaoyi commented Jan 11, 2026

Attempts to fix http://github.com/scala/scala3/issues/24142, vibe coded

Seems like a straightforward regex fix that doesn't require a claude explanation

Copy link
Contributor

@som-snytt som-snytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish they had thought of that on Scala 2.

I wonder if there is completion for solo colon.

@Gedochao Gedochao added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Jan 13, 2026
@Gedochao Gedochao added this to the 3.8.1 milestone Jan 13, 2026
@Gedochao Gedochao merged commit 5c01725 into scala:main Jan 13, 2026
56 checks passed
WojciechMazur pushed a commit that referenced this pull request Jan 13, 2026
Attempts to fix http://github.com/scala/scala3/issues/24142, vibe coded

Seems like a straightforward regex fix that doesn't require a claude
explanation
[Cherry-picked 5c01725]
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Jan 13, 2026
WojciechMazur added a commit that referenced this pull request Jan 13, 2026
…to 3.8.1 (#24964)

Backports #24942 to the 3.8.1-RC1.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Jan 13, 2026
tgodzik added a commit to scala/scala3-lts that referenced this pull request Jan 24, 2026
Attempts to fix http://github.com/scala/scala3/issues/24142, vibe coded

Seems like a straightforward regex fix that doesn't require a claude
explanation
[Cherry-picked 5c01725][modified]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:done This PR was successfully backported.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants