Skip to content

Sri.refactor input #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 4, 2024
Merged

Sri.refactor input #2

merged 5 commits into from
Sep 4, 2024

Conversation

szkieb
Copy link
Collaborator

@szkieb szkieb commented Sep 4, 2024

No description provided.

@szkieb szkieb self-assigned this Sep 4, 2024
@szkieb
Copy link
Collaborator Author

szkieb commented Sep 4, 2024

Description

  • refactor(index.js): remove console log
  • refactor(Input): checkClassName function added to remove duplicate code
  • refactor(Input): remove obsolete type assertions
  • refactor(Input): use optional chaining in if checks
  • refactor(Input): remove presentation role from input element (Interactive DOM elements should not have non-interactive ARIA roles, see link)
  • test(helpers): add test for checkClassName function

@szkieb
refactor(Input): extract helper function; add test
8a74737 
checkClassName function added to avoid duplicate code, adding test to verify accuracy
@szkieb
refactor(types): add ClassName type
be2960b 
avoiding duplicate code and improve readability
@szkieb szkieb marked this pull request as ready for review September 4, 2024 14:24
@szkieb szkieb merged commit bb2c7bd into main Sep 4, 2024
@szkieb szkieb deleted the sri.refactor-input branch September 4, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@szkieb szkieb

Labels
Priority:Low Type:Refactor Type:Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@szkieb