Skip to content

Conversation

@KrumBoychev
Copy link

Use initial redirect URL for fingerprint

@codecov-io
Copy link

codecov-io commented Jul 12, 2017

Codecov Report

Merging #21 into master will decrease coverage by 1.97%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage    91.3%   89.33%   -1.98%     
==========================================
  Files           2        2              
  Lines          69       75       +6     
  Branches        9       10       +1     
==========================================
+ Hits           63       67       +4     
- Misses          3        4       +1     
- Partials        3        4       +1
Impacted Files Coverage Δ
scrapy_deltafetch/middleware.py 89.04% <77.77%> (-2.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea3c34...f4df957. Read the comment docs.

@KrumBoychev
Copy link
Author

The case can be handled with custom 'deltafetch_key' in meta, so this feature is not needed:

`import hashlib

request = scrapy.Request(url, callback=self.parse_item,
meta={'deltafetch_key': hashlib.sha1(original_url).hexdigest()})`

@KrumBoychev KrumBoychev deleted the redirect_url_fingerprint branch October 24, 2017 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants