switch from travis to github actions #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelmhm
force-pushed
the
github-actions
branch
4 times, most recently
from
d2a4662 to
c3dd220
Compare
Contributor
|
You could also still use Tox, and run Tox from GitHub Actions, which is the approach we follow in Scrapy. The Scrapy GitHub Actions configuration is rather complex, but you could take inspiration from Spidermon’s . |
Collaborator
Author
|
@Gallaecio it's not that complex, I added it in scrapyrt, just need to fix test and it'll be fine. |
pawelmhm
force-pushed
the
github-actions
branch
from
1bd4807 to
b3a42eb
Compare
Collaborator
Author
|
ok @Gallaecio I added actions next steps on the roadmap:
|
replace bsddb with berkeleydb bsddb3 is deprecated install libdb-dev in github actions [requirements-test] proper requirements for tests tests directory, add __init__ library does not support Python 3.6 now (due to bsddb) This will be fixed on next PR. Here we only fix builds Revert "replace bsddb with berkeleydb" This reverts commit 478dd33. [github workflows] add caching of requirements
pawelmhm
force-pushed
the
github-actions
branch
from
b3a42eb to
43eb4a2
Compare
Gallaecio
approved these changes
Apr 26, 2021
Contributor
Gallaecio
left a comment
Gallaecio
left a comment
There was a problem hiding this comment.
I see you are still not using Tox, which I find confusing given the conversation in this issue (maybe a misunderstanding?). In any case, I have no strong opinion on that, using pytest directly works as well.
pawelmhm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.