Allow user to ignore some requests #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolohow
reviewed
Jul 13, 2021
scrapy_deltafetch/middleware.py
Outdated
| return to_bytes(key) | ||
|
|
||
| def _is_ignored(self, request): | ||
| return request.meta.get('deltafetch_ignore') is not None |
There was a problem hiding this comment.
request.meta.get('deltafetch_ignore', False)
tests/test_deltafetch.py
Outdated
|
|
||
| # 'test_key_1' is already in the test db --> it should be skipped | ||
| Request('http://url1', meta={'deltafetch_key': 'test_key_1'}) | ||
| Request('http://url1', meta={'deltafetch_key': 'test_key_1'}), |
|
Looks good, thanks @complikator I'll review and check if we can add it to next release coming |
|
I added docs and changed setting name, adjusted tests and merged your work here #44 Thanks very much for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can add
deltafetch_ignoreto your request metadata if you don't want to treat request as visited.