Skip to content

fix deprecated calls to scrapy.utils.request.request_fingerprint #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix deprecated calls to scrapy.utils.request.request_fingerprint #50

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3740fdf
ci: update python versions to test against
vinnymeller Nov 19, 2024
a9cd2da
fix: update calls to removed function request_fingerprint
vinnymeller Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
ci: update python versions to test against
  • Loading branch information
@vinnymeller
vinnymeller committed Nov 19, 2024
commit 3740fdf8b01ba8f2d5e9577e73671e221d389621
6 changes: 3 additions & 3 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.5, 3.6, 3.7, 3.8, 3.9]
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
Copy link
Author

@vinnymeller vinnymeller Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.5 and 3.6 don't seem to work anymore? at least in my fork


steps:
- uses: actions/checkout@v2
Expand All @@ -21,7 +21,7 @@ jobs:
sudo apt-get install libdb-dev

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Cache pip
Expand All @@ -38,4 +38,4 @@ jobs:
pip install -r tests/requirements-test.txt
- name: Test with pytest
run: |
pytest
pytest