Investigate OnHierarchyChangeListener as readiness indicator for screenshot#112
Draft
EmilioBejasa wants to merge 2 commits into
Draft
Investigate OnHierarchyChangeListener as readiness indicator for screenshot#112EmilioBejasa wants to merge 2 commits into
EmilioBejasa wants to merge 2 commits into
Conversation
…enshot Uses ViewGroup.setOnHierarchyChangeListener on the surface root view to get a direct, non-polling callback the moment Fabric mounts its first child. Followed by a re-layout pass before snapping the screenshot. Produces a non-blank screenshot without polling. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…dicator Adds a test that asserts the listener fires without taking a screenshot, mirroring the childCountTest structure on the predraw-listener branch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to #111. Investigates
ViewGroup.setOnHierarchyChangeListeneras an event-driven alternative to pollingchildCount > 0.hierarchyListenerTest: asserts the listener fires when Fabric mounts its first child — no screenshot, just the indicatoraddViewHookTest: same setup, then re-layouts and snaps a screenshotWhy
The
onChildViewAddedcallback fires synchronously the moment Fabric callsaddViewon the surface root — no polling loop needed. Uses a public Android API without subclassing.Test plan
hierarchyListenerTestpasses — confirms the signal is reachableaddViewHookTestpasses with non-blank screenshot ("Hello" visible)🤖 Generated with Claude Code