Skip to content

Wait for idle sync before capturing screenshot #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EmilioBejasa wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Wait for idle sync before capturing screenshot #86

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9dc196d
Wait for idle sync before capturing screenshot
EmilioBejasa Mar 18, 2026
7cdea7e
Fix flaky screenshots: double waitForIdleSync and loud timeout
EmilioBejasa Mar 19, 2026
746e3b3
Use 5 idle sync rounds to handle SwitchCompat's multi-pass rendering
EmilioBejasa Mar 19, 2026
b2d566e
Fix flaky screenshots: await Choreographer frames + disable animations
EmilioBejasa Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Wait for idle sync before capturing screenshot 
After JS calls notifyStoryReady() (end of useEffect), Fabric may still
have pending layout and mount work queued on the main thread. Taking the
screenshot immediately could capture a partially-rendered frame.

waitForIdleSync() drains the main thread's Looper before snap() runs,
ensuring all native view updates are applied first.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
  • Loading branch information
@EmilioBejasa @claude
EmilioBejasa and claude committed Mar 18, 2026
commit 9dc196dd9f12565d057c250831904e32016a47aa
3 changes: 3 additions & 0 deletions ...reenshots/android/src/main/java/com/rnstorybookautoscreenshots/BaseStoryScreenshotTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ abstract class BaseStoryScreenshotTest {
StorybookRegistry.prepareForNextStory()
renderStory(storyName) { view ->
StorybookRegistry.awaitStoryReady(getLoadTimeoutMs())
// Wait for the main thread to drain any pending Fabric layout/mount work
// that may still be in flight after JS signals ready.
InstrumentationRegistry.getInstrumentation().waitForIdleSync()
val screenshotName = storyInfo.id.replace("--", "_")
Screenshot.snap(view).setName(screenshotName).record()
Log.d(TAG, "Screenshot captured: $screenshotName")
Expand Down
Loading