Skip to content

Use loadStory to switch stories on a single surface instead of remounting #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EmilioBejasa wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Use loadStory to switch stories on a single surface instead of remounting #92

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5465b41
Use loadStory to switch stories on a single surface instead of remoun…
EmilioBejasa Mar 23, 2026
ce5e65b
Fix loadStory events not reaching JS: use DeviceEventEmitter
EmilioBejasa Mar 23, 2026
44d4d46
Merge branch 'main' of https://github.com/screenshotbot/react-native-…
EmilioBejasa Mar 24, 2026
d9f698a
Sync main thread before screenshot to fix Fabric timing race
EmilioBejasa Mar 24, 2026
14dcbde
Replace runOnMainSync with Choreographer frame wait for screenshot ti…
EmilioBejasa Mar 24, 2026
51aeedd
Run Screenshot.snap().record() explicitly on the main thread
EmilioBejasa Mar 24, 2026
95b2475
Remount surface per story instead of switching via loadStory events
EmilioBejasa Mar 25, 2026
639bda6
Pass story ID directly to StoryRenderer, fixing hierarchical titles
EmilioBejasa Mar 25, 2026
ce1fbcc
Wait for createPreparedStoryMapping in bootstrap before story loop
EmilioBejasa Mar 25, 2026
2c83b66
Always warm up before story loop, not just on missing manifest
EmilioBejasa Mar 25, 2026
aabfec3
Mount surface once and drive stories via loadStory() on the main thread
EmilioBejasa Mar 26, 2026
254d091
Use emitDeviceEvent instead of getJSModule for loadStory
EmilioBejasa Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run Screenshot.snap().record() explicitly on the main thread 
The library detects when it's already on the UI thread and skips its
own Handler dispatch, so there's no deadlock. Being explicit here makes
it clear that the draw always happens on the main thread, consistent
with the Choreographer frame wait above.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
  • Loading branch information
@EmilioBejasa @claude
EmilioBejasa and claude committed Mar 24, 2026
commit 51aeedd0961fa13e7b273cf3b6d6d5d3bf2eba6b
4 changes: 3 additions & 1 deletion ...reenshots/android/src/main/java/com/rnstorybookautoscreenshots/BaseStoryScreenshotTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,9 @@ abstract class BaseStoryScreenshotTest {
}
frameLatch.await(1000, TimeUnit.MILLISECONDS)
val screenshotName = story.id.replace("--", "_")
Screenshot.snap(view).setName(screenshotName).record()
InstrumentationRegistry.getInstrumentation().runOnMainSync {
Screenshot.snap(view).setName(screenshotName).record()
}
Log.d(TAG, "Screenshot captured: $screenshotName")
successCount++
} catch (e: Exception) {
Expand Down
Loading