Skip to content

Experiment: JS-driven story loop with Promise handshake #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EmilioBejasa wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Experiment: JS-driven story loop with Promise handshake #95

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fcd912
experiment: JS-driven story loop with Promise handshake
EmilioBejasa Mar 27, 2026
725b997
fix: bypass _preview.ready() and call notifyStoryReady directly in ef…
EmilioBejasa Mar 27, 2026
2fba6a9
fix: add ViewHelpers layout before Screenshot.snap on new arch
EmilioBejasa Mar 30, 2026
85e68ad
fix: recursively set LAYER_TYPE_SOFTWARE before Screenshot.snap
EmilioBejasa Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: add ViewHelpers layout before Screenshot.snap on new arch 
Without an explicit measure/layout pass, Screenshot.snap(surface.view)
captures a blank bitmap on Fabric. Mirror what the old arch path already
does with ViewHelpers so the view tree is software-rendered and properly
sized before capture.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
  • Loading branch information
@EmilioBejasa @claude
EmilioBejasa and claude committed Mar 30, 2026
commit 2fba6a905309c2738143a104267e00cd6695fc93
4 changes: 4 additions & 0 deletions ...reenshots/android/src/main/java/com/rnstorybookautoscreenshots/BaseStoryScreenshotTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,10 @@ abstract class BaseStoryScreenshotTest {

val screenshotName = storyId.replace("--", "_")
instrumentation.runOnMainSync {
ViewHelpers.setupView(view)
.setExactWidthPx(SCREEN_WIDTH_PX)
.setExactHeightPx(SCREEN_HEIGHT_PX)
.layout()
Screenshot.snap(view).setName(screenshotName).record()
}
Log.d(TAG, "Screenshot captured: $screenshotName")
Expand Down
Loading