Skip to content

added forwardRef + imperativa handle to handle inner methods#203

Merged
scriptex merged 2 commits into
scriptex:masterfrom
matheusnasser:master
May 19, 2023
Merged

added forwardRef + imperativa handle to handle inner methods#203
scriptex merged 2 commits into
scriptex:masterfrom
matheusnasser:master

Conversation

@matheusnasser
Copy link
Copy Markdown
Contributor

Implemented forwardRef + imperative Handle to enable accessing component methods from outside, allowing users to control the component externally.

Introduced the slideOnClick prop, which enables users to navigate directly to a specific item in the carousel by clicking on it.

I would greatly appreciate your thoughts on how to enhance the code and incorporate additional features.

Thank you in advance,
Matheus Nasser

@vercel
Copy link
Copy Markdown

vercel Bot commented May 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-round-carousel ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 0:35am

@scriptex scriptex self-requested a review May 15, 2023 07:18
@scriptex scriptex self-assigned this May 15, 2023
@scriptex scriptex added enhancement New feature or request good first issue Good for newcomers labels May 15, 2023
Copy link
Copy Markdown
Owner

@scriptex scriptex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @matheusnasser, thank you very much for your contribution!
I've added some minor comments and questions, can you please check them out? Thanks! ❤️

Comment thread src/index.tsx
Comment thread src/index.tsx Outdated
Comment thread src/index.tsx Outdated
 to onClick on carousel item type, and fixed wrong condition
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@scriptex
Copy link
Copy Markdown
Owner

Hey, @matheusnasser, can you please update the demo by adding the new configuration settings?

@matheusnasser
Copy link
Copy Markdown
Contributor Author

I'll work on that.

@scriptex
Copy link
Copy Markdown
Owner

@matheusnasser if the demo causes troubles we can try and merge your code and then I take over updating the demo.

@matheusnasser
Copy link
Copy Markdown
Contributor Author

I've been busy with some stuff at work that's why i wasn't able to update it, sry for that.

If you want to take over the demo would be awesome.

@scriptex scriptex merged commit cccfb2f into scriptex:master May 19, 2023
@scriptex
Copy link
Copy Markdown
Owner

@matheusnasser the demo has been updated and the new functionality has been released to NPM. Please download and install v1.4.0
Thank you very much for your contribution! ❤️

@matheusnasser
Copy link
Copy Markdown
Contributor Author

Thank you for the support and updating the demo! rly appreciate it! Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants