fix: consider floor gas in eth_estimateGas

[Thegaram]

1. Purpose or design rationale of this PR

Currently, the binary search in eth_estimateGas considers ErrFloorDataGas a true error case and terminates gas estimation. Instead, we should handle it as a special case, similar to ErrIntrinsicGas.

> cast estimate --rpc-url http://l2geth-rpc-0.sepolia.scroll.tech:8545 0x2a03a891add2dc6d0f7b94419086630ba5cb65b6 0x95d89b41 0x

Error: server returned an error response: error code -32000: err: insufficient gas for floor data gas cost: have 21151, want 21160 (supplied gas 21151)

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

• This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
• Yes

4. Breaking change label

Does this PR have the breaking-change label?

• This PR is not a breaking change
• Yes

Summary by CodeRabbit

• Bug Fixes

  • Improved gas estimation by expanding error handling to recognize additional intrinsic gas errors, resulting in more accurate gas limit suggestions.

• Chores

  • Updated the application patch version.

[coderabbitai]

Walkthrough

The changes update error handling in gas estimation logic to recognize both core.ErrIntrinsicGas and core.ErrFloorDataGas as special cases, prompting an increase in the gas limit during estimation. Additionally, the patch version in the params package is incremented from 72 to 73.

Changes

File(s)	Change Summary
accounts/abi/bind/backends/simulated.go	Expanded error handling in EstimateGas to include core.ErrFloorDataGas as a special case.
internal/ethapi/api.go	Updated DoEstimateGas logic to treat core.ErrFloorDataGas like core.ErrIntrinsicGas.
params/version.go	Incremented VersionPatch constant from 72 to 73.

Estimated code review effort

2 (~10–30 minutes)

Suggested labels

bump-version

Suggested reviewers

• omerfirmak
• colinlyguo

Poem

A tweak to gas, a version hop,
Two errors now make the search not stop.
Patch seventy-three, a gentle nudge,
Simulators and APIs both budge.
With every hop, the code grows neat—
A rabbit’s work is never complete! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef17a69 and a6b454f.

📒 Files selected for processing (3)

• accounts/abi/bind/backends/simulated.go (1 hunks)
• internal/ethapi/api.go (1 hunks)
• params/version.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: semgrep/ci
• GitHub Check: test
• GitHub Check: build-mock-ccc-geth
• GitHub Check: check
• GitHub Check: Analyze (go)

🔇 Additional comments (3)

params/version.go (1)

27-27: Version increment looks appropriate for this bug fix.

The patch version increment from 72 to 73 correctly follows semantic versioning for the gas estimation error handling improvements.

accounts/abi/bind/backends/simulated.go (1)

541-541: LGTM! Consistent error handling for gas estimation.

The addition of core.ErrFloorDataGas to the special case handling correctly aligns with the PR objective to treat floor data gas errors similar to intrinsic gas errors. This change is consistent with the corresponding modification in internal/ethapi/api.go, ensuring uniform behavior across different gas estimation implementations.

internal/ethapi/api.go (1)

1202-1202: Excellent fix for gas estimation handling.

The addition of core.ErrFloorDataGas to the special case error handling correctly implements the PR objective. This ensures that floor data gas errors no longer prematurely terminate the binary search algorithm in gas estimation, allowing it to continue and find an appropriate gas limit. The change maintains consistency with the simulated backend implementation.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.