Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Issue 6/automatic port selection #29

Open
fastner wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Issue 6/automatic port selection #29

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a0d676
Add get-port dependency
fastner Mar 1, 2018
a592047
Use get-port in dev server to get random port if dev port is not avai…
fastner Mar 1, 2018
5b44976
Give user hint that port is not free
fastner Mar 1, 2018
465d5f4
Use port-authority instead of get-port
fastner Mar 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Give user hint that port is not free
  • Loading branch information
@fastner
fastner committed Mar 1, 2018
commit 5b449767cf4bd4a7289c8b056afc840835f2bce1
8 changes: 7 additions & 1 deletion packages/edge-builder/src/webpack/dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,15 @@ export function connectWithWebpack(server, multiCompiler) {
serverIsStarted = true

try {
const serverPort = await getPort(process.env.SERVER_PORT)
const expectedPort = parseInt(process.env.SERVER_PORT, 10)
const serverPort = await getPort(expectedPort)

server.listen(serverPort, () => {
if (serverPort !== expectedPort) {
console.log(
`Port ${expectedPort} is not free. Using ${serverPort} instead`
)
}
notify(`Server started at port ${serverPort}`, "info")

writeToClipboard(`http://localhost:${serverPort}`)
Expand Down