Skip to content

Implement processed code coverage data mapper #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Implement processed code coverage data mapper #1028

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8002119
First pass at toJson method
AndrewFeeney Jan 21, 2024
45f8ddd
First pass at fromJson method
AndrewFeeney Jan 21, 2024
1aafb1b
Extract string key to constant
AndrewFeeney Jan 21, 2024
408ec71
Use full coverage test setup methods
AndrewFeeney Jan 22, 2024
00c1de2
Use constant for key
AndrewFeeney Jan 22, 2024
e6e69bf
Use camel case for keys
AndrewFeeney Jan 22, 2024
1bba525
Make test case names more specific
AndrewFeeney Jan 22, 2024
822dedc
Include function coverage
AndrewFeeney Jan 22, 2024
83112b5
Separate testing for path and function coverage
AndrewFeeney Jan 25, 2024
dfe7b55
Extract repeated setup steps to helper
AndrewFeeney Jan 25, 2024
4c86758
Extract repeated setup steps to private method
AndrewFeeney Jan 25, 2024
9b33999
Add a sanity check end-to-end test producing an XML file
AndrewFeeney Jan 25, 2024
6b09e8f
Add missing psalm annotiation
AndrewFeeney Jan 25, 2024
51e5fac
Code style fixes
AndrewFeeney Jan 25, 2024
d551ba9
Skip file cleanup if the tmp directory has not been created
AndrewFeeney Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Extract string key to constant
  • Loading branch information
@AndrewFeeney
AndrewFeeney committed Jan 21, 2024
commit 1aafb1be0a3ed59eb8e7559356de84e4384a9de5
6 changes: 4 additions & 2 deletions src/Data/ProcessedCodeCoverageDataMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@
*/
final class ProcessedCodeCoverageDataMapper
{
const KEY_LINE_COVERAGE = 'line_coverage';

public function toJson(ProcessedCodeCoverageData $processedCodeCoverageData): string
{
$arrayMapping = [
'line_coverage' => $processedCodeCoverageData->lineCoverage(),
self::KEY_LINE_COVERAGE => $processedCodeCoverageData->lineCoverage(),
];

return json_encode($arrayMapping);
Expand All @@ -33,7 +35,7 @@ public function fromJson(string $json): ProcessedCodeCoverageData

$processedCodeCoverageData = new ProcessedCodeCoverageData();

$processedCodeCoverageData->setLineCoverage($unserializedData['line_coverage']);
$processedCodeCoverageData->setLineCoverage($unserializedData[self::KEY_LINE_COVERAGE]);

return $processedCodeCoverageData;
}
Expand Down