Skip to content

Support parenthesis in the covers annotation #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2012
+9 −6
Merged

Support parenthesis in the covers annotation #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PHP/CodeCoverage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ protected function getLinesToBeCovered($className, $methodName)
}

$match = preg_match_all(
'(@covers\s+(?P<coveredElement>.*?)\s*$)m',
'(@covers\s+(?P<coveredElement>.*?)\s*(\(\s*\))?\s*$)m',
$docComment,
$matches
);
Expand Down
13 changes: 8 additions & 5 deletions Tests/PHP/CodeCoverageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ protected function setUp()
$this->getLinesToBeCovered = new ReflectionMethod(
'PHP_CodeCoverage', 'getLinesToBeCovered'
);

$this->getLinesToBeCovered->setAccessible(TRUE);
}

Expand Down Expand Up @@ -235,10 +235,13 @@ public function testClear()
}

/**
* @covers PHP_CodeCoverage::start
* @covers PHP_CodeCoverage::stop
* @covers PHP_CodeCoverage::append
* @covers PHP_CodeCoverage::applyListsFilter
* Add parenthesis to the covers annotation below in a couple of different ways to make sure it
* works as expected
*
* @covers PHP_CodeCoverage::start()
* @covers PHP_CodeCoverage::stop( )
* @covers PHP_CodeCoverage::append ()
* @covers PHP_CodeCoverage::applyListsFilter ( )
* @covers PHP_CodeCoverage::initializeFilesThatAreSeenTheFirstTime
* @covers PHP_CodeCoverage::applyCoversAnnotationFilter
* @covers PHP_CodeCoverage::getTests
Expand Down