Skip to content

Make test cases covering each line unique #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2015
Merged

Make test cases covering each line unique #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make test cases covering each line unique 
merge() function uses array_unique(), here it was forgotten. The coverage object was growing out of bounds.
  • Loading branch information
@petrusek
petrusek committed Feb 5, 2015
commit dca6c6fcb04060e9c0e600336ca416e139282814
4 changes: 3 additions & 1 deletion src/CodeCoverage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,9 @@ public function append(array $data, $id = null, $append = true, $linesToBeCovere

foreach ($lines as $k => $v) {
if ($v == 1) {
$this->data[$file][$k][] = $id;
if (empty($this->data[$file][$k]) || !in_array($id, $this->data[$file][$k])) {
$this->data[$file][$k][] = $id;
}
}
}
}
Expand Down