This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Added php7 to travis allowed_failures #114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
The tests pass on PHP 7 at the moment. |
Author
|
@sebastianbergmann so it is hhvm (?). |
Owner
|
What does this have to do with HHVM? If a change in PHP 7 causes a problem in phpcpd then phpcpd needs to be fixed. |
Author
|
hhvm is in the "allow_failures". |
Owner
|
Yes, because I do not care as much about HHVM than about PHP. |
Author
|
Ok, sorry for wasting your time then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that we should add the PHP7 to the allowed_failures for now. It's very likely that the BC will exists sooner or later and we don't want a Red build because of that.